fix(#3196): utils.read_file may hold onto fd#3197
fix(#3196): utils.read_file may hold onto fd#3197sepruko wants to merge 1 commit intonvim-tree:masterfrom sepruko:sepruko/fix-read-file
Conversation
Signed-off-by: Natalie Sepruko <me@sepruko.dev>
|
It looks like that function is unused. It was added for gitignore support eadead6 which has been rewritten several times over the years. We use git itself to track ignored now, rather than reading the Have you got a use case that uses this function? Maybe a recipe or extension plugin? I reckon we should just delete this function. |
I'm not overly familiar with the codebase, I was just perusing GitHub for the status quo on reading from a file and noticed this bug. I could've sworn I did a
No, and anything of the sort I feel can just roll their own similarly written function.
Probably, the entire file it's in seems to be using the deprecated |
fixes #3196